fix(app:linux): prevent infinite loop on file backstage#15362
Open
fix(app:linux): prevent infinite loop on file backstage#15362
Conversation
Contributor
|
Would love to get it fixed; can you re-base ? :-) |
…tainer refreshVisibleAreaRectangle() enters an infinite retry loop when the document container is hidden and the anchor section has zero size. BackstageView in CODA triggers this by hiding #document-container while multi-page view is active. Return early when the anchor has zero dimensions. Includes a coda-qt WebdriverIO regression test. cool#15291 Signed-off-by: Sarper Akdemir <sarper.akdemir@collabora.com> Change-Id: I39d99c9d32d92a8892634cfe42f4b078b9e149a3
Move duplicated file-open-via-native-dialog logic into a reusable openFixture() helper in qt/test/lib/file-dialog.ts. Signed-off-by: Sarper Akdemir <sarper.akdemir@collabora.com> Change-Id: I1a1d9177dd82ea50be099844372c7d61d6d74461
Quwex
force-pushed
the
private/quwex/fix-15291
branch
from
00d46ff to
04e4362
Compare
Contributor
Author
|
@gokaysatir I believe ViewLayoutMultipage is an area you were working on, if so I'd appreciate it if you could review the change :) |
gokaysatir
approved these changes
Apr 9, 2026
Contributor
gokaysatir
left a comment
gokaysatir
left a comment
There was a problem hiding this comment.
Of course. The layout code change looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay